Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto layout fixes #7618

Merged
merged 9 commits into from
Mar 8, 2016
Merged

Auto layout fixes #7618

merged 9 commits into from
Mar 8, 2016

Conversation

pec1985
Copy link
Contributor

@pec1985 pec1985 commented Jan 6, 2016

No description provided.

@pec1985
Copy link
Contributor Author

pec1985 commented Mar 1, 2016

@cheekiatng merge me!

@pec1985
Copy link
Contributor Author

pec1985 commented Mar 1, 2016

This is the command line I'm using for testing through the terminal:

cd {repo}/iphone/layout
xcodebuild -scheme layout -sdk iphonesimulator -destination 'platform=iOS Simulator,name=iPad Air 2,OS=9.2' test

@@ -152,24 +172,25 @@ -(void)layoutSubviews
-(void)addSubview:(nonnull UIView *)view
{
WRAP_TI_VIEW(view)
[_contentView addSubview:wrapperView];
[wrapperView setBackgroundColor:[UIColor redColor]];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be [UIColor clearColor] or nil ?

@cheekiatng
Copy link
Contributor

CR and FT passed.

cheekiatng added a commit that referenced this pull request Mar 8, 2016
@cheekiatng cheekiatng merged commit 2b9a5ab into tidev:master Mar 8, 2016
@cheekiatng cheekiatng mentioned this pull request Mar 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants